Mich,

I found a regression in 5.29.If I run stunnel.exe or tstunnel.exe with no arguments, having a configuration file stunnel.conf in the current directory, the program segfaults. This works fine on 5.28 or previous versions.

I uploaded a dump file to http://www.osronline.com/page.cfm?name=Analyze and the report pointed to a call to strncpy. Then, I ran a diff between 5.28 and 5.29 sources  and this sent me to file options.c, function options_cmdline. I found that in the call  strncpy(configuration_file, name, PATH_MAX-1), name was null. The problem is that variable name initialized at the begining of the function is garbled at the end.  The following patch fixed the issue for me:

--- options.c.old       Tue Dec 22 18:09:39 2015
+++ options.c   Mon Jan 04 23:14:29 2016
@@ -272,8 +272,11 @@
     } else
 #endif
     {
-        name=arg1;
-        type=CONF_FILE;
+        if (arg1)
+       {
+               name=arg1;
+               type=CONF_FILE;
+       }
     }

 #ifdef HAVE_REALPATH


Regards,

Jose A. Diaz


On Monday, January 4, 2016 4:11 PM, Michal Trojnara <Michal.Trojnara@mirt.net> wrote:


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Guys,

This Friday I intend to release stunnel 5.29.

The planned list of changes:

* New features
  - New WIN32 icons.
  - Performance improvement: rwlocks used for locking with pthreads.

* Bugfixes
  - Compilation fix for *BSD.
  - Fixed configuration file reload for relative stunnel.conf path
    on Unix.
  - Fixed ignoring CRLfile unless CAfile was also specified (thx
    to Strukov Petr).

Feel free to try stunnel 5.29b3, so I can fix any
discovered issues before the final release:
https://www.stunnel.org/downloads.html

Best regards,
    Mike
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCAAGBQJWit/iAAoJEC78f/DUFuAUtv8P/izyH0DIhUsDCWbYlyWRJDjr
2lwE1sYwmmMqtArM31N25QtRidEbZgTbuWQXaXY7/HALTnnI1VbDrbtAntVkovQr
FDXGlVvkife2IuSDS92b8ezEuq5swCQoT6KoHJDj9yLBSTQdZNxGHv9GfbS90mmv
fX3zcWmh+SklYnVgGrnc3GfgecaUS261KArdW1BTfA5ucydzse9z9X+2/iA7zl7i
wwvSHkfH3+Q3VsmJaSmoHTiMqzRzvH0NpKnbm0J5OfOql/fT9Mfn57U5ZGnC5iWP
bLlPmmP+fC7WLX8Cwl2DWESJ8kxPn2xEJbDGeCn9uzI0feKXMLwF/yrJopYVetIx
fJDgts4iR8eFRcFcSIpBrnWxNoTi4RhCzuIj8U/zYOBsHJPs6gPcuDG9fYtPXhF8
D93e8HeOW7naNyi+mTDjBo8qdiGGh+/ITp1PkNonVgFCWkxLIpfS2k6iQ/DqNTXd
szMU+uLeub5vt3ifRnSieTpIDTAsSbp0jarlXFRQNrUB0Cl8sgv/Ssl+ZYnDRyIa
2aTrK00eSc1nk+kZGJg5kTJM/t6PzfxtDUhVo5Pr6u9gwa94c34AHQ04W5dA7rTV
4pD4DxpFEk+2Syndjt6lncT/O2at3aYUkhyTZ/tN8/P22v1OWp+ci1WIpNXp/zVX
z12IUAFfyQPIuvdwLzZr
=CEXd
-----END PGP SIGNATURE-----
_______________________________________________
stunnel-users mailing list
stunnel-users@stunnel.org
https://www.stunnel.org/cgi-bin/mailman/listinfo/stunnel-users