[stunnel-users] Fwd: Comments/questions to Debian patches

[Michal Trojnara]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dear Users,

Peter Pentchev, the Debian package maintainer for the "stunnel4"
package, does not reply to my emails.  I hope he is still alive and
well, just too busy to maintain the package.

I decided to share with you my comments to the patches that are
applied to the Debian package.  Hopefully, someone will find them useful.

Mike

- -------- Forwarded Message --------
Subject: Comments/questions to Debian patches
Date: Tue, 28 Oct 2014 21:13:25 +0100
From: Michal Trojnara <Michal.Trojnara at mirt.net>
To: Peter Pentchev <roam at ringlet.net>

Hi Peter,

Just a few comments/questions to improve the quality of Debian package.
I'll be glad to discuss if you disagree with my opinions.

01-fix-paths.patch

The patch description is quite outdated.  Translation from sbin to bin
was performed upstream in stunnel 4.21 released 27 Oct 2007.  8-)

I guess:
/usr/bin/stunnel -fd 10 \
should be:
/usr/bin/stunnel4 -fd 10 \
Probably this should be added to the next patch:
02-rename-binary.patch

05-logrotate-warning-in-sample-conf.patch

Good idea.  I'll add it to stunnel 5.07.

08-client-example.patch

I've already added this example in stunnel 5.02.
Your patch adds it once again.  Just remove it.

10-no-zlib-compression.patch

I'm completely confused by this patch.  According to my tests it only
makes stunnel reporting different errors when a user tries to enable
compression on Debian.  Why would anyone need this patch?

11-no-rle-compression.patch

IMHO OpenSSL bugs should be fixed in OpenSSL, and not in stunnel.
YMMV

12-restore-pidfile-default.patch

I strongly disagree with this approach, as it breaks configuration
file compatibility with the upstream.  Debian should instead rewrite
stunnel.conf when upgrading from stunnel 4.xx.

14-lsb-init-functions.patch

8-)

15-upstream-systemd-libs.patch

This (and more) will be included in stunnel 5.07.

16-upstream-sslv23-method.patch

This will be included in stunnel 5.07.

Mike
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJVNsCAAAoJEC78f/DUFuAUpfUP/j13koMgtnVLfsACIqUEaZw3
1uADOP/Dugqbn/QcwSqWAlcTrf7So98AQrB88xAhN8C3fwP375GmcNmPgJx4RRme
fU/Wo0aFaCq0JOReiQkNiyj3pqf+J2NxZlZM5ZpzzpA80x8AlyLqBwPfBAtxgYNJ
rb5AyIoGPkzfXM8OSz8YJXZtgXT4lrSCE5djlWHHBqy9ioUZCEuyVXeT5Y90sXOg
wOA/EX3fTKEJZckoiNoTPAh9pLZ9M29lLM7wLEu5BFWwh/TtHk0ZFADo3Kzi/+4G
Q6h9236DmH1NHA/FzMfFbKEYz/0yeOUMfet8LsRNNRRrFJEp+miMemSYajGMA3IT
UVW4UNOa+CppVgkRpVMGfl/Lw53GP63xbLIRuZs17py03hNBHz2pyZneWWKTJEun
xJQC4QJ3Z3YYXd71jpHIKjcDBXmIzcG8Z9QylaTywk8MBBBpjuRTXkIAlWWj2Iyk
LVRsAgtooUKlQzUoAoseRygDv+Wbp/qVNL1Zogy7PmfORmqZOz08jRpDlXFgjPjR
evGztgApTR+FSMO9f052z/Sql0chb5mhtdAtdBKpRE3CgtIrCHfcalSOyeCleHJK
NMEbqfed9Oq2WA0/W89ilGtJWRH4v0GnYCfbYhbSoXp9DytdHPbhRUsiJL8LO34b
1cuMSsQ9LjF+3WyRie4m
=SrZs
-----END PGP SIGNATURE-----