- stunnel-users - stunnel.org

public domain [PATCH] to stunnel 500b3 for Windows CE / Windows Mobile, "no log window bug" on WCE, UNICODE wce/w32, and compilation issues fixed
by Pierre DELAAGE 18 Dec '12

18 Dec '12

Dear All, Please find enclosed a patch in "diff -cr orig patched" format, applying to stunnel v500b3 as found here https://www.stunnel.org/downloads.html This patch mainly addresses compilation and unicode issues for Windows CE targets + ONE issue preventing stunnel to display error logs in error Window on WCE. This code has been made common to WCE AND W32, by selecting proper win32 api calls common to both platforms. For example : InsertMenuItem does not exist on WCE, but InsertMenu can do the same job. ShellExecute does not exist on WCE, but...ShellExecuteEx does exist on both platforms and can do the job. I use MS EVC 4sp4 compiler with WCE 420 SDK, on a vista sp2 host platform. Once debugged the code works fine on WM6 HTC smartphones. Should work on WM5. It needs a windows CE openssl lib (I recompiled MY patched version of openssl 1.0.2snap20121213 successfully: I have sent a patch to those openssl gentlemen, hoping that they will integrate it one fine day..., something not so obvious ...). You will find my openssl "patch to port", by following carefully this thread at openssl diffusion list : http://marc.info/?l=openssl-dev&m=135574071824906&w=2 two messages are more important than the others : one containing the patch on the code. Another one containing 2 useful scripts. The present stunnel patch addresses the following issues : ************* I] COMPILATION FAILURES It is important to state that to detect more type mismatching (that can be error prone at runtime), I delibarately use /WX option on both WCE and W32 compilers: this flag takes each warning as an error. This is very useful for UNICODE clean coding as, without this option, the compiler will just warn when seeing a short* (unicode string) used as a char* (ansi string), which leads to big pb at run time. 1/ orig/src/client.c just a warning on missing "return". 2/ evc.mak new SSLDIR to openssl V102snap20121213 Missing flag x86 needed to get inline function InterlockedExchange from winbase.h. Added dependency to evc.mak itself, as in vc.mak Added commctrl.lib for CommandBar routines (although, strangely, the program was running without that !) 3/ gui.c : UNICODE port for W32/WCE. WM_WINDOWSPOSCHHANGED replaces WM_SHOWINDOW, as the latter is unsupported in WCE. some mismatch between prototype and function definition for service_install. Visible now is a BOOL, as it is more consistant with its value and usage. Some "return TRUE" have been replaced by "return 0" as stated in msdn doc. Trick to delete menuitems : itemcount does not exist in WCE, but the delete loop is using the return value of deletemenu. message_boxT created for Tchar vars such as section->help ShellExecute replaced by shellExecuteEx, common to WCE and W32 4/ prototypes.h : declared message_boxT 5/ resolver.c : UNICODE issue on LoadLibrary 6/ stunnel.c type cast for time_t 7/ vc.mak : inc32 for openssl includes /WX warning as error flag to see every potential casting problem around UNICODE ************* II] OPERATIONAL ERRORS (at run-time) 1/ error log windows is displayed empty : cause = WM_SHOWWINDOW does not exist on WCE, although the constant is declared ! solution : use WM_WINDOWPOSCHANGED instead... 2/ Unsolved, unfortunaltely : on WCE only, on start, there is an error message, but no real error behind : "CommandBar_InsertMenuBar : error 120 : this function is only valid in win32 mode" I am still searching... ************* III] MINOR IMPROVMENT 1/replaced some win3.1 ugly fonts See resources.rc : some nice FONT on About and Password dlgbox...to replace ugly windows3.1 style bold font... Note : I use stunnel to establish a simple "vpn" between smartphones and a corporate linux server mainly for HTTPS/POPS/SMTPS support. Stunnel is very relevant in that matter, over solutions based on SSH (although we use also ssh), from a communication cost point of view : ssh establishes permanent socket between client and server, so that the communication is charged by the mobile network provider : and these charges are very expensive. On the contrary stunnel only establishes ssl sockets on demand so that financial charges are limited to strict necessary. Please note that stunnel brings "client based certificate authentication" to POP/SMTP mobile mail user agents which only BASICALLY supports SSL with server authentication, but NO client authentication, such as M$ Outlook for Mobile (unless you pay for an exchange server and exchange client licence). Here again stunnel is very relevant. Note 2 : TODO list and Wish list : 1/ there is a remaining runtime bug on WCE : On start there is a warning that is NOT causing any failure in the software. Very difficult to analyse... 2/ find a notepad for WCE... 3/ in log.c...I really it would be good to replace hard coded values for socket errors by symbolic constant. 4/ fips openssl for WCE and then stunnel for WCE... I hope you will find this patch useful. Michal, thank you for your excellent work, Yours sincerely, Pierre Delaage

2 1

WCE 3.0 run-time error, how to work around it?
by Bao, Robert 12 Dec '12

12 Dec '12

Mike, The stunnel version used in our current product is 4.34. It worked well under Windows CE 3.0 and 5.0. However I got run-time error for 5.00 beta version under WCE 3.0 (even though I disabled IPv6, took out winsock2.h/ws2tcpip.h, included winsock.h, defined "struct addrinfo", etc ). The error is: Error detected on SSL (read) file descriptor: Bad protocol option (WSAENOPROTOOPT) (10042) What else I need to do to resolve or work around it? Thank you. Robert Bao Software House Tyco International

2 2

Win CE build errors: main_execute() removed from stunnel.c file? "hwnd" link error.
by Bao, Robert 07 Dec '12

07 Dec '12

Came across another Win CE build issue in the current stunnel 4.54 version. Got link error for main_execute() referenced in nogui.c file. I noticed that the implementation of "main_execute()" was in stunnel.c file in old versions, but is not there anymore. Also got "hwnd" linking issue. Looks like "hwnd" is initialized/created in gui.c file, and used in log.c/client.c/option.c files. It is not initialized/created in nogui.c file. I am using the NOGUIOBJS/tstunnel.exe option in building the stunnel, and got this linking error. Any suggestions on how to fix these or work around them? Thanks. Robert Bao Software House Tyco International 978-577-4202 Explore our new Tyco Online Learning Center Web-based Training Bundles at: www.swhouse.com/support/tyco_online_learning_center.aspx This e-mail may contain or have attached to it information or technology the export or re-export of which is restricted by U.S. laws and regulations. By viewing this e-mail and any attachments, the recipient agrees to the following: (i) the recipients use of the contents of this e-mail and any attachments shall comply with all applicable laws, rules and regulations, including, without limitation, U.S. international trade laws and regulations, and (ii) the recipient may not transfer or otherwise export or re-export any information or technology contained in this e-mail or any attachment except in full compliance with the export controls administered by the U.S. and other countries and any applicable import and use restrictions.

3 12

protocols options clarification
by John A. Wallace 06 Dec '12

06 Dec '12

The Service Level Options of the manual includes the following points: protocol = proto application protocol to negotiate SSL (e.g. starttls or stls) protocol option should not be used with SSL encryption on a separate port. Currently supported protocols: CIFS Connect Etc.. However, in the listed protocols supported neither "starttls" or "stls" appears, even though they appear to be options as far as I can see from the above explanation. Am I missing something here, or should they be among those in the list, and can one use this setting: Protocol=starttls Also, I don't really understand what this statement is telling me: "protocol option should not be used with SSL encryption on a separate port." John A. Wallace

3 2

Re: [stunnel-users] protocols options clarification
by jw72253＠verizon.net 06 Dec '12

06 Dec '12

2 1

how to use My Own Signed Wildcard cert
by robbi3j 05 Dec '12

05 Dec '12

Can anyone help ... have looked through the forums but cannot get this to work I want to configure Stunnel to use my already signed wildcard cert how to I go about importing it ? .. i have the cert file with the private key attached which is password protected can anyone help as its driving me nuts ! -- View this message in context: http://old.nabble.com/how-to-use-My-Own-Signed-Wildcard-cert-tp34756779p347… Sent from the Stunnel - Users mailing list archive at Nabble.com.

3 3

Console-only version for Windows
by Clodo 03 Dec '12

03 Dec '12

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 There is a binary version of stunnel for Windows WITHOUT the gui, console/terminal only? I have some different problems with the GUI edition: - - Fail to read filename with spaces? - - If is already in execution and i run stunnel.exe with some other parameters, they are ignored and simply give the focus to the current instance, so issue with launching multiple instances. Why there isn't any console-only version, exacly like the standard linux distribution? The Cygwin version works great, but isn't portable, doesn't work without Cygwin environment. There are some big trouble about that, or simply doesn't exists the .mak project file? I'm also available to pay with a donation a build like that. I'm waiting for feedback. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEVAwUBUKPN8i/ixHrG0m4LAQLxdwf/RF1faK3tksXnl6qm8Bi6HIFaG72tmFMJ LwQuY0gJh7rYDJs3NUQwh4XczMqi+5a8/SRZFojSewI2WfeZgLuXC58iq5nkAULm quaEN5ynjen80RJ7MtGg9weoHcpV1kug5HKJUwYZLU0lp8CvEGNhl8sgGT/bCUS7 gzdfi1d3YohBbEn8XZZgmmUmp1oShY4dh47Sd4vVlzaL3WkxqNIasCJJCwWk7lUz dPuy8XCi6y+Aes1T2SF87GAwvdkr0FbPiN0GcCXGczZxNjOiGNGOwqaHnxDknibr kHoGU/vv1PKWU5AYGiryD/YiUt0nHC/7I7IKU3tFu3smmFR8BTOwKA== =lLyE -----END PGP SIGNATURE-----

4 5

Patch to fix: Wildcard SSL certificates + SNI broken on Firefox
by Stephen Balukoff 29 Nov '12

29 Nov '12

Hello! I noticed that when dealing with wildcard certs in stunnel where an SNI configuration is being used, unless a specific servername context that exactly matches the browser's requested servername is in the stunnel.conf, stunnel responds to the client (web browser in this case) with a SSL_TLSEXT_ERR_ALERT_FATAL. Most browsers fall back to a non-SNI request, at which point, stunnel responds with whatever the master service's certificate is (which, if it's a wildcard cert, just works). However, at least one popularly-used web browser (Firefox) does not do this, and instead returns an error message to the user which they cannot (and should not need to) override to view the site contents. Since it's impractical to list all the possible servernames that can match at wildcard cert, and it's also impractical to expect the Firefox developers to change the behavior of their browser (when they shouldn't have to), and even more impractical to expect all the current users of Firefox to upgrade in a timely manner... I went ahead and wrote a patch for stunnel which instructs it to look for a matching wildcard certificate, if an exactly-matching servername isn't found. I've attached this patch to this message. Beyond fixing the stunnel+wildcard cert+SNI+firefox problem above, the secondary benefits of this patch are: * stunnel now responds immediately with a matching cert in the case of a wildcard cert, thus eliminating that first exchange which results in the SSL_TLSEXT_ERR_ALERT_FATAL error above. For stupid browsers and configurations with keepalive turned off + lots of requests per page and high latency, this should help to significantly improve performance. * stunnel will still choose an exactly matching cert if it's available and configured. (ie. if the browser requests 'subdomain.example.com', and there's a certificate configured in stunnel for 'subdomain.example.com' and another for '*.example.com', stunnel will respond with the ' subdomain.example.com' cert.) * one can now use multiple wildcard certs on a single IP:Port combination thanks to SNI. (Without this patch, you can effectively only use one wildcard cert per IP:Port combination with stunnel.) One note: It's been years since I've written any C code, so can't really vouch for the quality of my patch. I'm hoping at least the maintainers of this project see the utility of the patch I'm providing and write something similar in non-stupid C. Thanks, Stephen -- Stephen Balukoff Blue Box Group, LLC (800)613-4305 x807

1 0

Question : prevent close-nofity alerts from stunnel-server
by bhakta79 29 Nov '12

29 Nov '12

Hello, I was trying MITM on a windows application (which talks to a M$ server). Stunnel was running on my windows xp machine. windows-client-app -> stunnel server ---> stunnel client --> M$ Server What I found is that stunnel server sends close notify alert to the windows client app which causes the client to suspend all further communication (busted windows-client of course!). I tried setting the TimeoutClose option to high values but I always saw the server sending close notify alert (is the timeout close only a client-side parameter?) Is there a way to configure server to not send close notify? stullen logs: 2012.11.28 18:32:12 LOG7[3908:5904]: SSL socket closed on SSL_read 2012.11.28 18:32:12 LOG7[3908:5904]: Sent socket write shutdown 2012.11.28 18:32:12 LOG7[3908:4232]: Socket closed on read 2012.11.28 18:32:12 LOG5[3908:5904]: Connection closed: 901 byte(s) sent to SSL, 38020 byte(s) sent to socket 2012.11.28 18:32:12 LOG7[3908:4232]: Sending close_notify alert 2012.11.28 18:32:12 LOG7[3908:4232]: SSL alert (write): warning: close notify 2012.11.28 18:32:12 LOG6[3908:4232]: SSL_shutdown successfully sent close_notify alert 2012.11.28 18:32:12 LOG7[3908:5904]: Remote socket (FD=356) closed <mailto:stunnel-users@stunnel.org> I finally ended up making this one line code-change to stop server from sending close alert that helped my MITM progress. src/client.c: if(!(SSL_get_shutdown(c->ssl)&SSL_SENT_SHUTDOWN) && !sock_open_rd && !c->sock_ptr) { s_log(LOG_DEBUG, "BHAKTA - HACK -> Skip Sending close_notify alert"); *! if(0 && SSL_version(c->ssl)!=SSL2_VERSION) { /* SSLv3, TLSv1 */* s_log(LOG_DEBUG, "Sending close_notify alert"); shutdown_wants_write=1; } else { /* no alerts in SSLv2, including the close_notify alert */ s_log(LOG_DEBUG, "Closing SSLv2 socket"); if(c->ssl_rfd->is_socket) shutdown(c->ssl_rfd->fd, SHUT_RD); /* notify the kernel */ if(c->ssl_wfd->is_socket) shutdown(c->ssl_wfd->fd, SHUT_WR); /* send TCP FIN */ /* notify the OpenSSL library */ SSL_set_shutdown(c->ssl, SSL_SENT_SHUTDOWN|SSL_RECEIVED_SHUTDOWN); } } Is there a way to prevent server from sending close notify alert by means of stunel.conf parameters? stunnel.conf: debug = 7 output = stunnel.log cert = fakecert.pem key = fakecert.key options = DONT_INSERT_EMPTY_FRAGMENTS socket = l:TCP_NODELAY=1 socket = r:TCP_NODELAY=1 [https] sslVersion = TLSv1 accept = 0.0.0.0:443 connect = 127.0.0.1:446 [https-client] client = yes sslVersion = TLSv1 accept = 127.0.0.1:446 connect = 172.24.244.11:443 TIMEOUTclose = 300

1 0

Re: [stunnel-users] WinCE link errors
by Bao, Robert 28 Nov '12

28 Nov '12

Brian, You are right. After changing the order, all wcecompatex.lib related link errors are gone! Thanks a lot. Also thank Pierre for dropping me another suggestion. Mike, When you get chance to update next time, you may consider changing this line (in evc.mak): From: LIBS=/NODEFAULTLIB coredll.lib corelibc.lib winsock.lib wcecompatex.lib libeay32.lib ssleay32.lib To: LIBS=/NODEFAULTLIB winsock.lib wcecompatex.lib libeay32.lib ssleay32.lib coredll.lib corelibc.lib Thank you all. Robert From: Brian Wilkins [mailto:bwilkins@gmail.com] Sent: Wednesday, November 28, 2012 5:15 PM To: Bao, Robert Subject: Re: [stunnel-users] WinCE link errors Maybe try changing the link order...? On Nov 28, 2012 5:10 PM, "Bao, Robert" <rbao(a)tycoint.com> wrote: Dear Mike and WinCE stunnel users out there, I am currently in the process of compiling/linking the latest stunnel (4.54) for our ARM and WinCE 5.0 based device. I noticed that this version requires coredll.lib and corelibc.lib in the final link process (defined in the LIBS variable), which the old ones (e.g., version 4.33) didn't. Anyway, I got a lot of linking errors (see below), and just wondering any of you have seen the same errors and how you get around with these errors. If you have any other suggestions please feel free to let me know too. Note: I could resolve the errors at the bottom, but I have trouble get rid of the errors relating to wcecompatex.lib(redir.obj). Thank you for your time. wcecompatex.lib(redir.obj) : error LNK2005: fopen already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: fclose already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: fread already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: fwrite already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: _getstdfilex already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: _fileno already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: fflush already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: feof already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: ferror already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: clearerr already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: fseek already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: ftell already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: _setmode already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: fgets already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: fprintf already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : warning LNK4006: fopen already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: fclose already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: fread already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: fwrite already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: _getstdfilex already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: _fileno already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: fflush already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: feof already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: ferror already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: clearerr already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: fseek already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: ftell already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: _setmode already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: fgets already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: fprintf already defined in coredll.lib(COREDLL.dll); second definition ignored Creating library ..\bin\ARMV4I\tstunnel.lib and object ..\bin\ARMV4I\tstunnel.exp options.obj : error LNK2001: unresolved external symbol WSAGetLastError network.obj : error LNK2001: unresolved external symbol WSAGetLastError stunnel.obj : error LNK2019: unresolved external symbol WSAGetLastError referenced in function daemon_loop ctx.obj : error LNK2001: unresolved external symbol WSAGetLastError client.obj : error LNK2019: unresolved external symbol WSAGetLastError referenced in function init_remote log.obj : error LNK2001: unresolved external symbol WSAGetLastError client.obj : error LNK2019: unresolved external symbol hwnd referenced in function win_new_chain log.obj : error LNK2019: unresolved external symbol hwnd referenced in function s_strerror options.obj : error LNK2001: unresolved external symbol hwnd log.obj : error LNK2019: unresolved external symbol WSASetLastError referenced in function s_log nogui.obj : error LNK2019: unresolved external symbol main_execute referenced in function main ..\bin\ARMV4I\tstunnel.exe : fatal error LNK1120: 4 unresolved externals NMAKE : fatal error U1077: 'link' : return code '0x460' Robert Bao Software House Tyco International 978-577-4202 Explore our new Tyco Online Learning Center Web-based Training Bundles at: www.swhouse.com/support/tyco_online_learning_center.aspx This e-mail may contain or have attached to it information or technology the export or re-export of which is restricted by U.S. laws and regulations. By viewing this e-mail and any attachments, the recipient agrees to the following: (i) the recipients use of the contents of this e-mail and any attachments shall comply with all applicable laws, rules and regulations, including, without limitation, U.S. international trade laws and regulations, and (ii) the recipient may not transfer or otherwise export or re-export any information or technology contained in this e-mail or any attachment except in full compliance with the export controls administered by the U.S. and other countries and any applicable import and use restrictions. _______________________________________________ stunnel-users mailing list stunnel-users(a)stunnel.org https://www.stunnel.org/cgi-bin/mailman/listinfo/stunnel-users

1 0

WinCE link errors
by Bao, Robert 28 Nov '12

28 Nov '12

Dear Mike and WinCE stunnel users out there, I am currently in the process of compiling/linking the latest stunnel (4.54) for our ARM and WinCE 5.0 based device. I noticed that this version requires coredll.lib and corelibc.lib in the final link process (defined in the LIBS variable), which the old ones (e.g., version 4.33) didn't. Anyway, I got a lot of linking errors (see below), and just wondering any of you have seen the same errors and how you get around with these errors. If you have any other suggestions please feel free to let me know too. Note: I could resolve the errors at the bottom, but I have trouble get rid of the errors relating to wcecompatex.lib(redir.obj). Thank you for your time. wcecompatex.lib(redir.obj) : error LNK2005: fopen already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: fclose already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: fread already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: fwrite already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: _getstdfilex already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: _fileno already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: fflush already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: feof already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: ferror already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: clearerr already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: fseek already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: ftell already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: _setmode already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: fgets already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : error LNK2005: fprintf already defined in coredll.lib(COREDLL.dll) wcecompatex.lib(redir.obj) : warning LNK4006: fopen already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: fclose already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: fread already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: fwrite already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: _getstdfilex already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: _fileno already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: fflush already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: feof already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: ferror already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: clearerr already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: fseek already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: ftell already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: _setmode already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: fgets already defined in coredll.lib(COREDLL.dll); second definition ignored wcecompatex.lib(redir.obj) : warning LNK4006: fprintf already defined in coredll.lib(COREDLL.dll); second definition ignored Creating library ..\bin\ARMV4I\tstunnel.lib and object ..\bin\ARMV4I\tstunnel.exp options.obj : error LNK2001: unresolved external symbol WSAGetLastError network.obj : error LNK2001: unresolved external symbol WSAGetLastError stunnel.obj : error LNK2019: unresolved external symbol WSAGetLastError referenced in function daemon_loop ctx.obj : error LNK2001: unresolved external symbol WSAGetLastError client.obj : error LNK2019: unresolved external symbol WSAGetLastError referenced in function init_remote log.obj : error LNK2001: unresolved external symbol WSAGetLastError client.obj : error LNK2019: unresolved external symbol hwnd referenced in function win_new_chain log.obj : error LNK2019: unresolved external symbol hwnd referenced in function s_strerror options.obj : error LNK2001: unresolved external symbol hwnd log.obj : error LNK2019: unresolved external symbol WSASetLastError referenced in function s_log nogui.obj : error LNK2019: unresolved external symbol main_execute referenced in function main ..\bin\ARMV4I\tstunnel.exe : fatal error LNK1120: 4 unresolved externals NMAKE : fatal error U1077: 'link' : return code '0x460' Robert Bao Software House Tyco International 978-577-4202 Explore our new Tyco Online Learning Center Web-based Training Bundles at: www.swhouse.com/support/tyco_online_learning_center.aspx This e-mail may contain or have attached to it information or technology the export or re-export of which is restricted by U.S. laws and regulations. By viewing this e-mail and any attachments, the recipient agrees to the following: (i) the recipients use of the contents of this e-mail and any attachments shall comply with all applicable laws, rules and regulations, including, without limitation, U.S. international trade laws and regulations, and (ii) the recipient may not transfer or otherwise export or re-export any information or technology contained in this e-mail or any attachment except in full compliance with the export controls administered by the U.S. and other countries and any applicable import and use restrictions.

2 1

equivalent to SSLHonorcipherorder in stunnel?
by Mehdi Bennani 28 Nov '12

28 Nov '12

Hi, I was wondering if there were a flag available in stunnel, that would be the equivalent of the Apache directive 'SSLHonorcipherorder' ? I would like to basically be able to 'force' server preferences, rather then client ones, during cipher negotiation SSL handshake. Thank you, Elextra-

2 1

Max Cookie Size
by Scott McKeown 20 Nov '12

20 Nov '12

Hi All, I was wondering if anyone knows if its possible to pass a 'really' large cookie through STunnel. I've just built the latest version again (output below). However, we have a client that is looking to pass 16Kb (yes I know please don't tell me this is a bad idea a I know this!) via a cookie. Since we are looking to include STunnel in our offerings I was wondering if we could increase or change the maximum allowed size. I have a script that will generate a test cookie of any size that I require to test with but I can only get an 8K cookie to work. Any help would be great. ~Yours, Scott [root@localhost ~]# stunnel -version stunnel 4.54 on x86_64-unknown-linux-gnu platform Compiled/running with OpenSSL 1.0.0-fips 29 Mar 2010 Threading:PTHREAD SSL:+ENGINE+OCSP+FIPS Auth:none Sockets:POLL+IPv6 Global options: debug = daemon.notice pid = /usr/local/var/run/stunnel/stunnel.pid RNDbytes = 64 RNDfile = /dev/urandom RNDoverwrite = yes Service-level options: ciphers = FIPS (with "fips = yes") ciphers = ALL:!SSLv2:!aNULL:!EXP:!LOW:-MEDIUM:RC4:+HIGH (with "fips = no") sessionCacheSize = 1000 sessionCacheTimeout = 300 seconds sslVersion = TLSv1 (with "fips = yes") sslVersion = TLSv1 for client, all for server (with "fips = no") stack = 65536 bytes TIMEOUTbusy = 300 seconds TIMEOUTclose = 60 seconds TIMEOUTconnect = 10 seconds TIMEOUTidle = 43200 seconds verify = none [root@localhost ~]# -- With Kind Regards. Scott McKeown Loadbalancer.org http://www.loadbalancer.org

2 2

Problem using stunnel on Windows 7
by Hal Hovland 18 Nov '12

18 Nov '12

I've spent days googling this and read everything relevant in the archives. I'm developing a Windows 7 program that connects to a financial trading exchange that expects all communication to be SSL'd. Everything I read said that stunnel is the answer because of ease of installation and use. After a day of abortive attempts to link to the exchange, I decided to create a much simpler test environment involving two Windows 7 computers next to each other here. One, let's call it Riven-II (192.168.1.9), is set up with a simple Listener program that listens on port 8000. From stunnel's viewpoint this will be a server. The second machine, Lightning (192.168.1.158), has a simple Sender program that sends a text message via port 7999 to Riven-II (192.168.1.9:8000) - this will be the Client. In the absence of stunnel, all messages sent from Lightning/Sender appears on the window of Listener. So far so good. I've downloaded and installed the very latest version (4.54) of stunnel on both machines. On installation I entered the same responses to the certificate generating process. On the Server machine, hard wired to a Broadband Router, I configured stunnel.conf as (removing comments for simplicity) debug = 7 output = stunnel.log socket = l:TCP_NODELAY=1 socket = r:TCP_NODELAY=1 cert = stunnel.pem key = stunnel.pem options = NO_SSLv2 taskbar=yes [Listener] connect=8000 accept=8001 On the Client machine, connected to the router via wi-fi, we have in stunnel.conf debug = 7 output = stunnel.log cert = stunnel.pem socket = l:TCP_NODELAY=1 socket = r:TCP_NODELAY=1 fips=no options = NO_SSLv2 delay=yes taskbar=yes client=yes [sender] accept = 0.0.0.0:7999 (I've tried just 7999 and 192.168.1.158:7999, here. Makes no difference) connect = 192.168.1.9:8001 I've tried many variations with the same result, but the above is where they have ended up. My understanding of this is that stunnel both ends will be intercepting port 8000 on the Server and port 7999 on the Client and presenting/receiving SSL encoded messages across the wire on port 8001. Starting stunnel in the Server (not as a Windows service, although I did try that as well) the following log appears: 2012.11.16 22:34:08 LOG7[3484:6184]: No limit detected for the number of clients 2012.11.16 22:34:08 LOG5[3484:6184]: stunnel 4.54 on x86-pc-msvc-1500 platform 2012.11.16 22:34:08 LOG5[3484:6184]: Compiled/running with OpenSSL 1.0.1c-fips 10 May 2012 2012.11.16 22:34:08 LOG5[3484:6184]: Threading:WIN32 SSL:+ENGINE+OCSP+FIPS Auth:none Sockets:SELECT+IPv6 2012.11.16 22:34:08 LOG5[3484:6184]: Reading configuration from file stunnel.conf 2012.11.16 22:34:08 LOG5[3484:6184]: FIPS mode is enabled 2012.11.16 22:34:08 LOG7[3484:6184]: Compression not enabled 2012.11.16 22:34:08 LOG7[3484:6184]: Snagged 64 random bytes from C:/.rnd 2012.11.16 22:34:08 LOG7[3484:6184]: Wrote 1024 new random bytes to C:/.rnd 2012.11.16 22:34:08 LOG7[3484:6184]: PRNG seeded successfully 2012.11.16 22:34:08 LOG6[3484:6184]: Initializing service [Listener] 2012.11.16 22:34:08 LOG7[3484:6184]: Certificate: stunnel.pem 2012.11.16 22:34:08 LOG7[3484:6184]: Certificate loaded 2012.11.16 22:34:08 LOG7[3484:6184]: Key file: stunnel.pem 2012.11.16 22:34:08 LOG7[3484:6184]: Private key loaded 2012.11.16 22:34:08 LOG7[3484:6184]: Could not load DH parameters from stunnel.pem 2012.11.16 22:34:08 LOG7[3484:6184]: Using hardcoded DH parameters 2012.11.16 22:34:08 LOG7[3484:6184]: DH initialized with 2048-bit key 2012.11.16 22:34:08 LOG7[3484:6184]: ECDH initialized with curve prime256v1 2012.11.16 22:34:08 LOG7[3484:6184]: SSL options set: 0x01000004 2012.11.16 22:34:08 LOG5[3484:6184]: Configuration successful 2012.11.16 22:34:08 LOG7[3484:6184]: Service [Listener] (FD=272) bound to 0.0.0.0:8001 On the Client, the log shows: 2012.11.16 22:25:53 LOG7[4184:4948]: No limit detected for the number of clients 2012.11.16 22:25:53 LOG5[4184:4948]: stunnel 4.54 on x86-pc-msvc-1500 platform 2012.11.16 22:25:53 LOG5[4184:4948]: Compiled/running with OpenSSL 1.0.1c-fips 10 May 2012 2012.11.16 22:25:53 LOG5[4184:4948]: Threading:WIN32 SSL:+ENGINE+OCSP+FIPS Auth:none Sockets:SELECT+IPv6 2012.11.16 22:25:53 LOG5[4184:4948]: Reading configuration from file stunnel.conf 2012.11.16 22:25:53 LOG5[4184:4948]: FIPS mode is disabled 2012.11.16 22:25:53 LOG7[4184:4948]: Compression not enabled 2012.11.16 22:25:53 LOG7[4184:4948]: Snagged 64 random bytes from C:/.rnd 2012.11.16 22:25:53 LOG7[4184:4948]: Wrote 1024 new random bytes to C:/.rnd 2012.11.16 22:25:53 LOG7[4184:4948]: PRNG seeded successfully 2012.11.16 22:25:53 LOG6[4184:4948]: Initializing service [sender] 2012.11.16 22:25:53 LOG7[4184:4948]: Certificate: stunnel.pem 2012.11.16 22:25:53 LOG7[4184:4948]: Certificate loaded 2012.11.16 22:25:53 LOG7[4184:4948]: Key file: stunnel.pem 2012.11.16 22:25:53 LOG7[4184:4948]: Private key loaded 2012.11.16 22:25:53 LOG7[4184:4948]: SSL options set: 0x01000004 2012.11.16 22:25:53 LOG5[4184:4948]: Configuration successful 2012.11.16 22:25:53 LOG7[4184:4948]: Service [sender] (FD=224) bound to 0.0.0.0:7999 Running the Listener on the Server and Sender on the Client adds nothing to the log, and port sniffers on both machines show traffic between 7999 and 8000 (exactly the same as when stunnel is not running). No sign of the use of port 8001. I'd appreciate any input on this. I'm sure I must be doing something stupid, but I've watched hours of YouTube videos, read many hundreds of web pages, and been through the documentation quite a few times, to no avail. I have a Java based version, running in a JVM in the same Windows machines, that talks perfectly to the exchange using some inbuilt SSL capabilities of an included library, so that should probably eliminate any hardware/router issues? Regards, Hal

4 10

log rotation
by Michael Curran 11 Nov '12

11 Nov '12

Are there any built in stunnel.conf parameters for log rotation? Im looking for windows based -- not logrotate on unix -- thats simple Do I need to use windows third party logrotate tools to make this happen instead?

2 1

High memory usage problem.
by Jeremy Frady 11 Nov '12

11 Nov '12

Thanks for taking the time to read this. We're operating on a low spec system that can not be modified at this point. stunnel was introduced at the last minute, without consideration to resource requirements and now consumes enough ram to cause the kernel to issue OOM exceptions. So in short, we are trying to trade increased CPU usage for less memory usage and have tried setting “sessions” to 3600 to reduce memory pressure, but unfortunately it doesn't last. Our current solution is to cron a restart of stunnel on a regular basis, but would prefer to limit number of threads or number of cache entries or something else altogether similarly gentler. Thanks again for your consideration and assistance in this! If there's any specific information I can give, please let me know. Regards, Jeremy

2 1

How do I re-encrypt ssl traffic with stunel?
by Arsen Zahray 11 Nov '12

11 Nov '12

I'm trying to set up wireshark debugging of ssl traffic by following this article: http://www.webos-internals.org/wiki/Decrypt_SSL_(trusted_man-in-the-middle_t echnique) It lists following stunnel commands to do the job: Listen on local IP and de-SSL traffic to localhost:8080 sudo stunnel -p ps.pem -d 443 -r 8080 Listen on 8080, re-SSL to remote server on 443 sudo stunnel -c -d 8080 -r ps.palmws.com:443 The article seems outdated, and stunnel does not react on these commands anymore. Can anyone provide me with a proper configuration file to do the same?

3 2

FIPS enablement
by Michael Curran 05 Nov '12

05 Nov '12

Hello I think there is a bit of confusion within my company on what stunnel can do in regards to FIPS 140-2 out of the box. I know there are configuration options that can enable or disable FIPS 140-2 mode, but as the man page indicates fips = yes | no Enable or disable FIPS 140-2 mode. This option allows to disable entering FIPS mode if stunnel was compiled with FIPS 140-2 support. default: yesWhich to me says I have to compile stunnel on my own using openssl with fips libraries to build a Stunnel binary that can support FIPS 140-2 compliance -- if I download just the windows or unix binaries and install them -- then I am not going to be 140-2 compliant where I set the config file to yes or no , since the FIPS modules wont be compiled into the binary. I'm just looking for confirmation before I take this back to the rest of my group. Thanks!! Michael Curran

3 2

Re: [stunnel-users] Fw: Using stunnel to add https to a webserver that doesn't have ssl setup
by mkanet＠yahoo.com 02 Nov '12

02 Nov '12

Thanks for the reply. Lots of friendly people on here. I should have probably posted my solution when I figured it out. I was already using a server-based method to handle redirection. However, what I didn't consider is adding a one line exception that distinguishes incoming requests from stunnel on 127.0.0.1 in order to prevent an endless loop. I did this by modifying my IIS URL Rewrite module rule to look like below. URL Rewrite module 2.0 is highly optimized; and is ideal for this kind of thing; works perfect under any circumstance; so long as webpages contain relative elements. Works like a charm. <rewrite> <rules> <rule name="HTTP to HTTPS redirect" stopProcessing="true"> <match url="(.*)" /> <conditions logicalGrouping="MatchAll"> <add input="{HTTPS}" pattern="off" ignoreCase="true" /> <add input="{REMOTE_ADDR}" pattern="127.0.0.1" negate="true" /> </conditions> <action type="Redirect" redirectType="Found" url="https://{HTTP_HOST}/{R:1}" /> </rule> </rules> </rewrite> ----- Forwarded Message ----- On Tue, 30 Oct 2012 15:05:54 -0700 (PDT) <mkanet(a)yahoo.com> wrote: > Thanks. I typically let my webserver handle SSL whenever I can since > it's much easier that way; especially since I know how to handle > http->https urlrewrites that way already; and, plenty of examples on > the web for IIS. The reasons for adding stunnel into the mix in this > scenerio completely outweight not having it at all. I couldn't find > any examples anywhere showing how to handle a simple http to https URL redirect if stunnel is involved; not even in javascript. > Hopefully someone here has the expertise to offer a solution at least in html. The easiest way is to use a server side language as PHP and ASP or CGI/perl (if ISS is capable, that I don't know). If you relay on client (javascript, meta refresh) you can't control the behavior of the client (javascript disabled by user or meta redirects). ISS is capable of PHP and, if you are using it, because you didn't tell, is easy (easy, but I haven't done as I don't know much of PHP (I just played a couple of times with it following tutorials)). With ASP, I don't know, but should be possible too. Here you have an example with PHP: http://www.iis-aid.com/articles/how_to_guides/three_methods_redirect_http_h… or this one: http://stackoverflow.com/questions/5106313/redirecting-from-http-to-https-w… (second message). As I said, you have to do it transparent to the user without relying on them.

1 0

Fw: Using stunnel to add https to a webserver that doesn't have ssl setup
by Michael Avanessian 02 Nov '12

02 Nov '12

Thanks. I typically let my webserver handle SSL whenever I can since it's much easier that way; especially since I know how to handle http->https urlrewrites that way already; and, plenty of examples on the web for IIS. The reasons for adding stunnel into the mix in this scenerio completely outweight not having it at all. I couldn't find any examples anywhere showing how to handle a simple http to https URL redirect if stunnel is involved; not even in javascript. Hopefully someone here has the expertise to offer a solution at least in html. On 30.10.2012 20:39, MKANET wrote > Thanks for the quick reply! So... what http code do I use to break > out the infinite loop so it loads only once? I'm afraid I can't answer that one, as you're using IIS and I'm Unices centered. FWIW, in situations where the port-80 service does *nothing but* hand out redirects to port 443, I typically let the full-blown webserver handle the HTTPS (whether natively or behind an SSL wrapper) and use a boilerplate PERL script (alas, not readily usable on Windows) for the redirecting. I've seen too many kinds of webserver doing redirections to autodetermined URLs that happen to miss some vital part of the originally requested URL, including some that *cause* the browser to drop from HTTPS back to HTTP in the first place. :-S Regards, ----- Forwarded Message ---- Thanks for the quick reply! So... what http code do I use to break out the infinite loop so it loads only once? I think the other 2 circumstances may have something similar happening to them (which are forwarded using the web server instead). If I use the webserver to rewrite the URL, the web browser tries to do something (I can't tell what), then returns the error below: The page isn't redirecting properly Firefox has detected that the server is redirecting the request for this address in a way that will never complete. > Normally, I could do this a few different ways (provided my webserver > had ssl added to it natively in a normal way) 1. webserver URL Rewrite > plugin 2. webserver redirect plugin > 3: > > For whatever reason, I'm having all sorts of weird issues when > trying the three methods above if I use stunnel for ssl instead of > using the webserver's builtin ssl. Please note that traffic coming out of the stunnel looks - and actually *is* - just as port-80-ish to the actual webserver as native HTTP requests do, so unless you take special measures to break the loop, the webserver will try to (re-)redirect *that, too*. Regards, J. Bern --

2 1

enabling https capability
by John A. Wallace 01 Nov '12

01 Nov '12

Not sure if this is the right place to ask, but I will give it a try because it seems likely that someone here can point me in the right direction if need be. I am not a programmer. I have an application that can make http connections but not https. The connections are made from a Windows command line interface, not a browser. I would like to enable it to make https connections too without having to reinvent the wheel. If there is some way to connect it to an intermediary proxy program that does have built-in support for the https protocol, that would be swell. Is such a thing possible or is there another solution I don't see? Thanks. John

2 1

Fwd: Trying to minimize memory usage for a scenario where we have several long-lived HTTPS connections.
by Jeremy Frady 31 Oct '12

31 Oct '12

Hello all, Thanks for taking the time to read this. We're operating on a low spec system that can not be modified at this point. stunnel was introduced at the last minute, without consideration to resource requirements and now consumes enough ram to cause the kernel to issue OOM exceptions. So in short, we are trying to trade increased CPU usage for less memory usage and have tried setting “sessions” to 3600 to reduce memory pressure, but unfortunately it doesn't last. Our current solution is to cron a restart of stunnel on a regular basis, but would prefer to limit number of threads or number of cache entries or something else altogether similarly gentler. Thanks again for your consideration and assistance in this! Regards, Jeremy

1 0

6 processes + out of memory issues on CentOS 6 stunnel (4.29)
by Todd Rinaldo 31 Oct '12

31 Oct '12

I'm experimenting with using the stunnel that comes with CentOS 6 (4.29). I have a config file that is successfully being used on stunnel version 4.15 on the same host without any issues. My issues: 1. starting stunnel creates 6 processes. I assume this has something to do with libwrap, but I'm not finding much discussion about it by doing a search. I'm also assuming that the binaries are forking after load, so it's not a significant memory expense to do this due to COW. Is this correct? 2. I'm getting 't of memory' (no "ou" in the error) messages from syslog when I do more than one request via chrome to port 2087. The process indicated from the message points to the stunnel process that has ownership of the open ports. A single request to this port doesn't seem to spawn the issue. Can anyone suggest what might be causing this? Upgrading to a newer version of stunnel is possible, but I would prefer to keep the version Red Hat provides so they can be on the hook for CVE issues. My config file follows: ----- cert = /var/cpanel/ssl/cpanel/cpanel.pem chroot = /usr/local/cpanel/var/run/stunnel/ # PID is created inside chroot jail pid = /stunnel.pid setuid = cpanel setgid = cpanel # Service-level configuration [cpanelhttps] accept = 2083 connect = 2082 TIMEOUTclose = 0 [whmhttps] accept = 2087 connect = 2086 TIMEOUTclose = 0 [webmailhttps] accept = 2096 connect = 2095 TIMEOUTclose = 0

1 0

Re: [stunnel-users] Using stunnel to add https to a webserver that doesn't have ssl setup
by Michael Avanessian 30 Oct '12

30 Oct '12

Thanks for the quick reply! So... what http code do I use to break out the infinite loop so it loads only once? I think the other 2 circumstances may have something similar happening to them (which are forwarded using the web server instead). If I use the webserver to rewrite the URL, the web browser tries to do something (I can't tell what), then returns the error below: The page isn't redirecting properly Firefox has detected that the server is redirecting the request for this address in a way that will never complete. > Normally, I could do this a few different ways (provided my webserver > had ssl added to it natively in a normal way) 1. webserver URL Rewrite > plugin 2. webserver redirect plugin > 3: > > For whatever reason, I'm having all sorts of weird issues when > trying the three methods above if I use stunnel for ssl instead of > using the webserver's builtin ssl. Please note that traffic coming out of the stunnel looks - and actually *is* - just as port-80-ish to the actual webserver as native HTTP requests do, so unless you take special measures to break the loop, the webserver will try to (re-)redirect *that, too*. Regards, J. Bern --

2 1

Using stunnel to add https to a webserver that doesn't have ssl setup
by Michael Avanessian 30 Oct '12

30 Oct '12

Hi there. I appreciate that you guys are all helping each other out. I am brand new to stunnel. Currently, I'm using stunnel to add https to a webserver that doesn't have ssl setup; which works great. I prefer to do that instead of using the webserver's builtin ssl feature. CONFIGURATION: Stunnel.conf includes (which adds ssl to incoming http traffic on port 443) [https] accept = 443 connect = 80 Also, incoming http:80 traffic can also come in; which would bypass stunnel, and go directly to the webserver as http. OBJECTIVE: I am trying to make it so when someone visits: http://mywebsite.com (it forwards automatically to https://mywebsite.com) Normally, I could do this a few different ways (provided my webserver had ssl added to it natively in a normal way) 1. webserver URL Rewrite plugin 2. webserver redirect plugin 3: <meta http-equiv="refresh" content="0; url=https://mywebsite.com"> For whatever reason, I'm having all sorts of weird issues when trying the three methods above if I use stunnel for ssl instead of using the webserver's builtin ssl. The first two methods result in web browser redirect errors, the third method result in an infinite loop reloading the https website. Can someone please tell me what extra accommodation I need to make considering that using stunnel for https can complicate things. I'm using IIS 7.5 as my webserver. I've tried using the the URL rewrite 2.0 mod using the below rule (which works for normal builtin ssl support in the webserver: <rule name="Redirect to HTTPS" stopProcessing="true"> <match url="(.*)" /> <conditions><add input="{HTTPS}" pattern="^OFF$" /> </conditions> </rule> I have also tried the "http redirect" mod; which I can forward to any website except for the one I'm trying to do. Both take me to the https equivalent and give a redirect error. Could someone please be kind enough to tell me what I'm missing? Thanks!

2 1